Andres Freund <and...@anarazel.de> writes: > On 2022-03-30 13:16:47 -0400, Robert Haas wrote: >> On Wed, Mar 30, 2022 at 1:11 PM Andres Freund <and...@anarazel.de> wrote: >>> My concern is about the quote in the middle of the path, not about quoting >>> at all... I.e. the ' should be after /tmp_install, not before.
>> Makes no difference. We know that the string /tmp_install contains no >> shell metacharacters, so why does it need to be in quotes? I would've >> probably written it the way it is here, rather than what you are >> proposing. > It looks ugly, and it can't be copy-pasted as easily. Seems I'm alone on this, > so I'll leave it be... FWIW, I agree with Andres that I'd probably have put the quote at the end. But Robert is right that it's functionally equivalent; so I doubt it's worth changing. regards, tom lane