On Sat, Apr 7, 2018 at 5:48 AM, Teodor Sigaev <teo...@sigaev.ru> wrote: > On close look, bts_btentry.ip_posid is not used anymore, I change > bts_btentry type to BlockNumber. As result, BTEntrySame() is removed.
That seems like a good idea. > I'm not very happy with massive usage of > ItemPointerGetBlockNumberNoCheck(&(itup->t_tid)), suggest to wrap it to > macro something like this: > #define BTreeInnerTupleGetDownLink(itup) \ > ItemPointerGetBlockNumberNoCheck(&(itup->t_tid)) Agreed. We do that with GIN. -- Peter Geoghegan