On 3/30/22 08:00, Dagfinn Ilmari Mannsåker wrote: > Robert Haas <robertmh...@gmail.com> writes: > >> This patch contains a trivial adjustment to >> PostgreSQL::Test::Cluster::run_log to make it return a useful value >> instead of not. I think that should be pulled out and committed >> independently regardless of what happens to this patch overall, and >> possibly back-patched. > run_log() is far from the only such method in PostgreSQL::Test::Cluster. > Here's a patch that gives the same treatment to all the methods that > just pass through to the corresponding PostgreSQL::Test::Utils function. > > Also attached is a fix a typo in the _get_env doc comment that I noticed > while auditing the return values. >
None of these routines in Utils.pm returns a useful value (unlike run_log()). Typically we don't return the value of Test::More routines. So -1 on patch 1. I will fix the typo. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
