On Tue, Mar 29, 2022 at 10:43:00AM +0530, Amit Kapila wrote: > On Mon, Mar 21, 2022 at 5:51 PM Euler Taveira <eu...@eulerto.com> wrote: > > On Mon, Mar 21, 2022, at 12:25 AM, Amit Kapila wrote: > > I have fixed all the above comments as per your suggestion in the > > attached. Do let me know if something is missed? > > > > Looks good to me. > > This patch is committed > (https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=208c5d65bbd60e33e272964578cb74182ac726a8).
src/test/subscription/t/029_on_error.pl has been failing reliably on the five AIX buildfarm members: # poll_query_until timed out executing this query: # SELECT subskiplsn = '0/0' FROM pg_subscription WHERE subname = 'sub' # expecting this output: # t # last actual query output: # f # with stderr: timed out waiting for match: (?^:LOG: done skipping logical replication transaction finished at 0/1D30788) at t/029_on_error.pl line 50. I've posted five sets of logs (2.7 MiB compressed) here: https://drive.google.com/file/d/16NkyNIV07o0o8WM7GwcaAYFQDPTkULkR/view?usp=sharing The members have not actually uploaded these failures, due to an OOM in the Perl process driving the buildfarm script. I think the OOM is due to a need for excess RAM to capture 029_on_error_subscriber.log, which is 27MB here. I will move the members to 64-bit Perl. (AIX 32-bit binaries OOM easily: https://www.postgresql.org/docs/devel/installation-platform-notes.html#INSTALLATION-NOTES-AIX.)
