This patch still has code warnings on the cfbot and I don't think they're platform-specific:
[00:28:28.236] gram.y: In function ‘base_yyparse’: [00:28:28.236] gram.y:2851:58: error: passing argument 2 of ‘makeDefElemExtended’ from incompatible pointer type [-Werror=incompatible-pointer-types] [00:28:28.236] 2851 | $$ = makeDefElemExtended(NULL, $2, NULL, DEFELEM_DROP, @2); [00:28:28.236] | ~~~~~~~~~^~~~~~~ [00:28:28.236] | | [00:28:28.236] | DefElem * [00:28:28.236] In file included from gram.y:58: [00:28:28.236] ../../../src/include/nodes/makefuncs.h:102:60: note: expected ‘char *’ but argument is of type ‘DefElem *’ [00:28:28.236] 102 | extern DefElem *makeDefElemExtended(char *nameSpace, char *name, Node *arg, [00:28:28.236] | ~~~~~~^~~~ I gather the patch is still a WIP and ideally we would want to give feedback on patches in CFs when the author's are looking for it but this is the last week before feature freeze and the main focus is on committable patches. I'll move it to next CF.
