On 3/28/22 15:56, Robert Haas wrote:
On Mon, Mar 21, 2022 at 4:15 PM Joe Conway <m...@joeconway.com> wrote:
Robert -- any opinion on this? If I am not mistaken it is code that you
are actively working on.
Woops, I only just saw this. I don't mind if you want to change the
calls to is_member_of_role() in basebackup_server.c and
basebackup_to_shell.c to has_privs_of_role().
Done as originally posted.
On that last note, I did not find basebackup_to_shell.required_role
documented at all, and did not attempt to fix that.
I saw that Robert added documentation and it already reads correctly I
believe, except possibly an unrelated issue:
8<--------------
<para>
A role which replication whose privileges users are required to
possess
in order to make use of the <literal>shell</literal> backup target.
If this is not set, any replication user may make use of the
<literal>shell</literal> backup target.
</para>
8<--------------
Robert, should that actually be:
s/role which replication/role with replication/
?
Joe
