On Thu, Mar 17, 2022 at 3:36 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > Did you see some old code I wrote towards this goal? > https://www.postgresql.org/message-id/20150215044814.gl3...@alvh.no-ip.org > The intention was that DDL would produce some JSON blob that accurately > describes the DDL that was run; >
I have read that thread and found one of your emails [1] where you seem to be saying that JSON representation is not required for BDR. Will in some way going via JSON blob way make this project easier/better? > the caller can acquire that and use it > to produce working DDL that doesn't depend on runtime conditions. > For runtime conditions, one of the things you have mentioned in that thread is to add schema name in the statement at the required places which this patch deals with in a different way by explicitly sending it along with the DDL statement. The other cases where we might need deparsing are Alter Table type cases (where we need to rewrite the table) where we may want to send a different DDL. I haven't analyzed but I think it is better to have a list where all we need deparsing and what is the best way to deal with it. The simpler cases seem to be working with the approach proposed by this patch but I am not sure if it will work for all kinds of cases. [1] - https://www.postgresql.org/message-id/20150504185721.GB2523%40alvh.no-ip.org -- With Regards, Amit Kapila.
