On Tue, Apr 12, 2022 at 11:31 AM houzj.f...@fujitsu.com <houzj.f...@fujitsu.com> wrote: > > On Tuesday, April 12, 2022 8:40 AM Peter Smith <smithpb2...@gmail.com> wrote: > > > > FYI, I was playing with row filters and partitions recently, and while doing > > something a bit unusual I received a cache leak warning. > > > > Below are the steps to reproduce it: > > > > > > test_pub=# CREATE TABLE parent(a int primary key) PARTITION BY RANGE(a); > > CREATE TABLE > > > > test_pub=# CREATE TABLE child PARTITION OF parent DEFAULT; CREATE TABLE > > > > test_pub=# CREATE PUBLICATION p4 FOR TABLE parent WHERE (a < 5), child > > WHERE (a >= 5) WITH (publish_via_partition_root=true); > > CREATE PUBLICATION > > > > test_pub=# ALTER PUBLICATION p4 SET TABLE parent, child WHERE (a >= 5); > > ALTER PUBLICATION > > > > test_pub=# ALTER PUBLICATION p4 SET (publish_via_partition_root = false); > > 2022-04-11 17:37:58.426 AEST [28152] WARNING: cache reference leak: > > cache pg_publication_rel (49), tuple 0/12 has count 1 > > WARNING: cache reference leak: cache pg_publication_rel (49), tuple > > 0/12 has count 1 > > ALTER PUBLICATION > > Thanks for reporting. > > I think the reason is that we didn't invoke ReleaseSysCache when rftuple is > valid and no filter exists. We need to release the tuple whenever the > rftuple is valid. Attach a patch which fix this. >
Thanks! Your patch could be applied cleanly, and the reported problem now seems fixed. ------ Kind Regards, Peter Smith. Fujitsu Australia.
