> On 14 Apr 2022, at 16:32, Peter Eisentraut 
> <peter.eisentr...@enterprisedb.com> wrote:
> 
> On 13.04.22 13:51, Daniel Gustafsson wrote:
>> 0002: Capitalizes pg_log_error_detail and conversely starts pg_log_error 
>> with a
>> lowercase letter without punctuation.
> 
> I'm having some doubts about some of these changes, especially for 
> interactive features in psql, where the messages are often use a bit of a 
> different style.  I don't think this kind of thing is an improvement, for 
> example:
> 
> -       pg_log_error("You are currently not connected to a database.");
> +       pg_log_error("you are currently not connected to a database");

That may also be a bit of Stockholm Syndrome since I prefer the latter error
message, but I see your point.

--
Daniel Gustafsson               https://vmware.com/



Reply via email to