On Wed, 20 Apr 2022 at 13:02, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > What's with the free text in cbstorage.h? I would guess that this > wouldn't even compile, and nobody has noticed because the file is not > included by anything yet ...
I'm not able to compile: cbfsmpage.c: In function ‘cb_fsmpage_initialize’: cbfsmpage.c:34:11: warning: unused variable ‘fsm_block_spacing’ [-Wunused-variable] unsigned fsm_block_spacing = cb_fsm_block_spacing(pages_per_segment); ^ cbfsmpage.c:33:14: warning: unused variable ‘first_fsm_block’ [-Wunused-variable] BlockNumber first_fsm_block = cb_first_fsm_block(pages_per_segment); ... cbxlog.c: In function ‘cb_xlog_allocate_payload_segment’: cbxlog.c:70:24: error: void value not ignored as it ought to be bool have_fsm_page = XLogRecGetBlockTag(record, 1, NULL, NULL, NULL); ^ cbxlog.c: In function ‘cb_xlog_allocate_index_segment’: cbxlog.c:123:17: error: void value not ignored as it ought to be have_prev_page = XLogRecGetBlockTag(record, 2, NULL, NULL, NULL); ^ cbxlog.c:124:16: error: void value not ignored as it ought to be have_fsm_page = XLogRecGetBlockTag(record, 3, NULL, NULL, NULL); ^ cbxlog.c: In function ‘cb_xlog_recycle_payload_segment’: cbxlog.c:311:16: error: void value not ignored as it ought to be have_metapage = XLogRecGetBlockTag(record, 0, NULL, NULL, NULL); ^ cbxlog.c:312:18: error: void value not ignored as it ought to be have_index_page = XLogRecGetBlockTag(record, 1, NULL, NULL, NULL); ^ cbxlog.c:313:16: error: void value not ignored as it ought to be have_fsm_page = XLogRecGetBlockTag(record, 2, NULL, NULL, NULL); ^ make[4]: *** [cbxlog.o] Error 1 make[4]: Leaving directory `/home/thom/Development/postgresql/src/backend/access/conveyor' make[3]: *** [conveyor-recursive] Error 2 make[3]: Leaving directory `/home/thom/Development/postgresql/src/backend/access' make[2]: *** [access-recursive] Error 2 -- Thom