On 18.04.22 20:53, Tom Lane wrote:
A semantics-preserving conversion would have looked something likeif (node->sortgrouprefs) WRITE_INDEX_ARRAY(sortgrouprefs, list_length(node->exprs)); I suppose that Peter was trying to remove special cases from the outfuncs.c code, but do we want to put this one back? Richard's proposal would not accurately reflect the contents of the data structure, so I'm not too thrilled with it.
I think we could put the if (node->fldname) inside the WRITE_INDEX_ARRAY macro.
