On Mon, Apr 9, 2018 at 10:46 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> After further contemplation I decided that that was, in fact, the only
> reasonable way to improve matters.  If we have multiple subdirectories
> independently firing the "make generated-headers" action, then we have
> parallel make hazards of just the same sort I was trying to prevent.
> So it's really an all-or-nothing proposition.  The MAKELEVEL hack
> plus wiring the prerequisite into the recursion rules is the best way
> to make that happen.
> Hence, done that way.

Compilation of external extensions using PGXS appears to be broken
since this commit:

make[1]: *** /tmp/pgbuild/lib/postgresql/pgxs/src/makefiles/../../src/backend:
No such file or directory.  Stop.
make: *** 
submake-generated-headers] Error 2

I think the best fix if to define NO_GENERATED_HEADERS in pgxs.mk,
patch attached.
diff --git a/src/makefiles/pgxs.mk b/src/makefiles/pgxs.mk
index c038836e73..a97ad2e0f5 100644
--- a/src/makefiles/pgxs.mk
+++ b/src/makefiles/pgxs.mk
@@ -60,6 +60,8 @@ $(error pgxs error: makefile variable PGXS or NO_PGXS must be set)
+# External extensions can't build the headers
 ifdef PGXS
 # We assume that we are in src/makefiles/, so top is ...

Reply via email to