Hi All, Currently, in postgres we have two different functions that are specially used to open the WAL files for reading and writing purposes. The first one is XLogFileOpen() that is just used to open the WAL file so that we can write WAL data in it. And then we have another function named XLogFileRead that does the same thing but is used when reading the WAL files during recovery time. How about renaming the function XLogFileRead to XLogFileOpenForRead and the other one can be renamed to XLogFileOpenForWrite. I think it will make the function name more clear and increase the readability. At least XlogFileRead doesn't look good to me, from the function name it actually appears like we are trying to read a WAL file here but actually we are opening it so that it can be read by some other routine.
Also I see that we are passing emode to the XLogFileRead function which is not being used anywhere in the function, so can we remove it? -- With Regards, Ashutosh Sharma.
