Mark Rofail wrote: > On Tue, Apr 10, 2018 at 3:59 PM, Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote: > > > > documentation to it and a few extensive tests to ensure it works well); > > I think the existing regression tests verify that the patch works as > expectations, correct?
I meant for the GIN operator. (Remember, these are two patches, and each of them needs its own tests.) > We need more *exhaustive* tests to test performance, not functionality. True. So my impression from the numbers you posted last time is that you need to run each measurement case several times, and provide averages/ stddevs/etc for the resulting numbers, and see about outliers (maybe throw them away, or maybe they indicate some problem in the test or in the code); then we can make an informed decision about whether the variations between the several different scenarios are real improvements (or pessimizations) or just measurement noise. In particular: it seemed to me that you decided to throw away the idea of the new GIN operator without sufficient evidence that it was unnecessary. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services