On Thursday, May 19, 2022 2:45 AM vignesh C <vignes...@gmail.com> wrote: > On Mon, May 16, 2022 at 8:32 AM osumi.takami...@fujitsu.com > <osumi.takami...@fujitsu.com> wrote: > > (3) src/test/regress/expected/publication.out > > > > +-- Verify that only superuser can reset a publication ALTER > > +PUBLICATION testpub_reset OWNER TO regress_publication_user2; SET > > +ROLE regress_publication_user2; ALTER PUBLICATION testpub_reset > > +RESET; -- fail > > > > > > We have "-- fail" for one case in this patch. > > On the other hand, isn't better to add "-- ok" (or "-- success") for > > other successful statements, when we consider the entire tests > > description consistency ? > > We generally do not mention success comments for all the success cases as > that might be an overkill. I felt it is better to keep it as it is. > Thoughts? Thank you for updating the patches !
In terms of this point, I meant to say we add "-- ok" for each successful "ALTER PUBLICATION testpub_reset RESET;" statement. That means, we'll have just three places to add "--ok" and I thought this was not an overkill. *But*, I'm also OK with your idea. Please don't change the comments and keep them as it is like v6. Best Regards, Takamichi Osumi