On Fri, May 20, 2022 at 02:45:19PM -0700, Nathan Bossart wrote: > Thanks for the new patch! I attached a new version with a few small > changes. What do you think?
So you have settled down to --member to emulate the clause ROLE. Well, this choice is fine by me at the end. > +$node->issues_sql_like( > + [ 'createuser', 'regress_role2', '-a', 'regress_user1' ], > + qr/statement: CREATE ROLE regress_role2 NOSUPERUSER NOCREATEDB > NOCREATEROLE INHERIT LOGIN ADMIN regress_user1;/, > + 'add a role as a member with admin option of the newly created role'); > +$node->issues_sql_like( > + [ 'createuser', 'regress_role3', '-m', 'regress_user1' ], > + qr/statement: CREATE ROLE regress_role3 NOSUPERUSER NOCREATEDB > NOCREATEROLE INHERIT LOGIN ROLE regress_user1;/, > + 'add a role as a member of the newly created role'); May I ask for the addition of tests when one specifies multiple switches for --admin and --member? This would check the code path where you build a list of role names. You could check fancier string patterns, while on it, to look after the use of fmtId(), say with role names that include whitespaces or such. -- Michael
signature.asc
Description: PGP signature
