On Tue, May 24, 2022 at 2:18 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Tue, May 24, 2022 at 7:58 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > On Mon, May 23, 2022 at 2:39 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > On Mon, May 23, 2022 at 10:03 AM Kyotaro Horiguchi > > > <horikyota....@gmail.com> wrote: > > > > > > > > At Sat, 21 May 2022 15:35:58 +0530, Amit Kapila > > > > <amit.kapil...@gmail.com> wrote in > > > > > I think if we don't have any better ideas then we should go with > > > > > either this or one of the other proposals in this thread. The other > > > > > idea that occurred to me is whether we can somehow update the snapshot > > > > > we have serialized on disk about this information. On each > > > > > running_xact record when we serialize the snapshot, we also try to > > > > > purge the committed xacts (via SnapBuildPurgeCommittedTxn). So, during > > > > > that we can check if there are committed xacts to be purged and if we > > > > > have previously serialized the snapshot for the prior running xact > > > > > record, if so, we can update it with the list of xacts that have > > > > > catalog changes. If this is feasible then I think we need to somehow > > > > > remember the point where we last serialized the snapshot (maybe by > > > > > using builder->last_serialized_snapshot). Even, if this is feasible we > > > > > may not be able to do this in back-branches because of the disk-format > > > > > change required for this. > > > > > > > > > > Thoughts? > > > > It seems to work, could you draft the patch? > > > > I can help with the review and discussion.
Okay, I'll draft the patch for this idea. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
