On Wed, Jun 22, 2022 4:49 PM Peter Smith <smithpb2...@gmail.com> wrote: > > On Wed, Jun 22, 2022 at 2:18 PM Amit Kapila <amit.kapil...@gmail.com> > wrote: > > > > On Thu, Jun 16, 2022 at 6:07 AM Peter Smith <smithpb2...@gmail.com> > wrote: > > > > > > > > Thank you for your review comments. Those reported mistakes are fixed > > > in the attached patch v3. > > > > > > > This patch looks mostly good to me except for a few minor comments > > which are mentioned below. It is not very clear in which branch(es) we > > should commit this patch? As per my understanding, this is a > > pre-existing behavior but we want to document it because (a) It was > > not already documented, and (b) we followed it for row filters in > > PG-15 it seems that should be explained. So, we have the following > > options (a) commit it only for PG-15, (b) commit for PG-15 and > > backpatch the relevant sections, or (c) commit it when branch opens > > for PG-16. What do you or others think? > > Even though this is a very old docs omission, AFAIK nobody ever raised > it as a problem before. It only became more important because of the > PG15 row-filters. So I think option (a) is ok. >
I also think option (a) is ok. > > PSA patch v4 to address all the above review comments. > Thanks for updating the patch. It looks good to me. Besides, I tested the examples in the patch, and there's no problem. Regards, Shi yu
