On Wed, Jul 6, 2022 at 10:24 AM Matthias van de Meent < boekewurm+postg...@gmail.com> wrote:
> On Thu, 9 Jun 2022 at 18:12, David G. Johnston > <david.g.johns...@gmail.com> wrote: > > > > Per suggestion over on -docs: > > > > > https://www.postgresql.org/message-id/bl0pr06mb4978f6c0b69f3f03aebed0fbb3...@bl0pr06mb4978.namprd06.prod.outlook.com > > I agree with moving the size of an enum into the top, but I don't > think that the label length documentation also should be included in > the top section. It seems excessively detailed for that section with > its reference to NAMEDATALEN. > > -Matthias > Agreed. Tangentially: It does seem a bit unusual to call the fact that the values both case-sensitive and limited to the length of a system identifier an implementation detail. But if anything the length is more of one than the case-sensitivity. Specifying NAMEDATALEN here seems like it breaks encapsulation, it could refer by comparison to an identifier and only those that care can learn how that length might be changed in a custom build of PostgreSQL. David J.
