On Thu, Jul 7, 2022 at 4:44 AM Kyotaro Horiguchi <horikyota....@gmail.com> wrote: > While working on a patch, I met a function with the signature of: > > > DropRelFileLocatorBuffers(SMgrRelation smgr_reln, ForkNumber *forkNum, > > int nforks, BlockNumber > > *firstDelBlock) > > It was DropRelFileNodeBuffers(), which means "Drop buffers for a > RelFileNode", where RelFileNode means a storage or a (set of) file(s). > In that sense, "Drop buffers for a RelFile*Locator*" sounds a bit off > to me. Isn't it better change the name? RelFileLocator doesn't look > to be fit here. > > "DropRelFileBuffers" works better at least for me.. If it does, some > other functions need the same amendment.
Have you looked at the commit message for https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=b0a55e43299c4ea2a9a8c757f9c26352407d0ccc ? -- Robert Haas EDB: http://www.enterprisedb.com
