Hi! We have branch with incremental commits worm where patches were generated with format-patch - https://github.com/postgrespro/postgres/tree/toasterapi_clean I'll clean up commits from garbage files asap, sorry, haven't noticed them while moving changes.
Best regards, Nikita Malakhov On Fri, Jul 1, 2022 at 3:27 PM Matthias van de Meent < boekewurm+postg...@gmail.com> wrote: > On Thu, 30 Jun 2022 at 22:26, Nikita Malakhov <huku...@gmail.com> wrote: > > > > Hi hackers! > > Here is the patch set rebased onto current master (15 rel beta 2 with > commit from 29.06). > > Thanks! > > > Just to remind: > > With this patch set you will be able to develop and plug in your own > TOAST mechanics for table columns. Knowing internals and/or workflow and > workload > > of data being TOASTed makes Custom Toasters much more efficient in > performance and storage. > > The new toast API doesn't seem to be very well documented, nor are the > new features. Could you include a README or extend the comments on how > this is expected to work, and/or how you expect people to use (the > result of) `get_vtable`? > > > Patch set consists of 9 incremental patches: > > [...] > > 0002_toaster_interface_v7.patch - TOAST API interface and SQL syntax > allowing creation of custom Toaster (CREATE TOASTER ...) > > and setting Toaster to a table column (CREATE TABLE t (data bytea > STORAGE EXTERNAL TOASTER bytea_toaster);) > > This patch 0002 seems to include changes to log files (!) that don't > exist in current HEAD, but at the same time are not created by patch > 0001. Could you please check and sanitize your patches to ensure that > the changes are actually accurate? > > Like Robert Haas mentioned earlier[0], please create a branch in a git > repository that has a commit containing the changes for each patch, > and then use git format-patch to generate a single patchset, one that > shares a single version number. Keeping track of what patches are > needed to test this CF entry is already quite difficult due to the > amount of patches and their packaging (I'm having troubles managing > these seperate .patch.gz), and the different version tags definitely > don't help in finding the correct set of patches to apply once > downloaded. > > Kind regards, > > Matthias van de Meent > > [0] > https://www.postgresql.org/message-id/CA%2BTgmoZBgNipyKuQAJzNw2w7C9z%2B2SMC0SAHqCnc_dG1nSLNcw%40mail.gmail.com >
