Hi, On 2022-07-11 11:53:26 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > I wonder if we can't abstract this at least a bit better. If we go that > > route > > a bit further, then add another arch, this code will be pretty much > > unreadable. > > IMO, it's pretty unreadable *now*, for lack of comments about what it's > doing and why.
Yea, that could at least be addressed by adding comments. But even with a bunch of comments, it'd still be pretty hard to read once the events above have happened (and they seem kind of inevitable). I wonder if we can add a somewhat more general function for scanning until some characters are found using SIMD? There's plenty other places that could be useful. Greetings, Andres Freund