On Sun, Jul 17, 2022 at 6:29 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Fri, Jul 15, 2022 at 3:32 PM shiy.f...@fujitsu.com > <shiy.f...@fujitsu.com> wrote: > > > > I've attached patches for all supported branches including the master. >
For back branch patches, * Wouldn't it be better to move purge logic into the function SnapBuildPurge* function for the sake of consistency? * Do we really need ReorderBufferInitialXactsSetCatalogChanges()? Can't we instead have a function similar to SnapBuildXidHasCatalogChanges() as we have for the master branch? That will avoid calling it when the snapshot state is SNAPBUILD_START or SNAPBUILD_BUILDING_SNAPSHOT -- With Regards, Amit Kapila.
