On Tue, Jul 19, 2022 at 11:34 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Mon, Jul 18, 2022 at 9:46 PM vignesh C <vignes...@gmail.com> wrote: > > > > I have updated the patch to handle the origin value case > > insensitively. The attached patch has the changes for the same. > > > > Thanks, the patch looks mostly good to me. I have made a few changes > in 0001 patch which are as follows: (a) make a comparison of origin > names in maybe_reread_subscription similar to slot names as in future > we may support origin names other than 'any' and 'none', (b) made > comment changes at few places and minor change in one of the error > message, (c) ran pgindent and slightly changed the commit message. > > I am planning to push this day after tomorrow unless there are any > comments/suggestions.
FYI, the function name in the comment is not same as the function name here: +/* + * IsReservedName + * True iff name is either "none" or "any". + */ +static bool +IsReservedOriginName(const char *name) ------ Kind Regards, Peter Smith. Fujitsu Australia
