On Fri, Jul 22, 2022 at 2:49 PM Amit Langote <amitlangot...@gmail.com> wrote: > On Fri, Jul 22, 2022 at 1:13 PM David Rowley <dgrowle...@gmail.com> wrote: > > BTW, I was working on code inside llvm_compile_expr() a few days ago > > and I thought I'd gotten the new evaluation steps I was adding correct > > as it worked fine with jit_above_cost=0, but on further testing, it > > crashed with jit_inline_above_cost=0. Might be worth doing both to see > > if everything works as intended. > > Thanks for the pointer. > > So I didn't see things going bust on re-testing with all > jit_*_above_cost parameters set to 0, so maybe the > llvm_compile_expression() additions are alright.
Here's an updated version of the patch, with mostly cosmetic changes. In particular, I added comments describing the new llvm_compile_expr() blobs. -- Thanks, Amit Langote EDB: http://www.enterprisedb.com
v5-0001-Some-improvements-to-JsonExpr-evaluation.patch
Description: Binary data
