Hi Michael, Not sure if this email went through previously but thank you for your feedback, I've incorporated your suggestions by scanning the logs produced from pg_rewind when asserting that certain WAL segment files were skipped from being copied over to the target server.
I've also updated the pg_rewind patch file to target the Postgres master branch
(version 16 to be). Please see attached.
Thanks,
Justin
________________________________
From: Justin Kwan <justinpk...@outlook.com>
Sent: July 18, 2022 1:14 PM
To: Tom Lane <t...@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hack...@postgresql.org>; vignesh
<vign...@cloudflare.com>; jk...@cloudflare.com <jk...@cloudflare.com>; vignesh
ravichandran <ad...@viggy28.dev>; hlinn...@iki.fi <hlinn...@iki.fi>
Subject: Re: Making pg_rewind faster
Hi Tom,
Thank you for taking a look at this and that sounds good. I will send over a
patch compatible with Postgres v16.
Justin
________________________________
From: Tom Lane <t...@sss.pgh.pa.us>
Sent: July 17, 2022 2:40 PM
To: Justin Kwan <justinpk...@outlook.com>
Cc: pgsql-hackers <pgsql-hack...@postgresql.org>; vignesh
<vign...@cloudflare.com>; jk...@cloudflare.com <jk...@cloudflare.com>; vignesh
ravichandran <ad...@viggy28.dev>; hlinn...@iki.fi <hlinn...@iki.fi>
Subject: Re: Making pg_rewind faster
Justin Kwan <justinpk...@outlook.com> writes:
> I've also attached the pg_rewind optimization patch file for Postgres version
> 14.4. The previous patch file targets version Postgres version 15 Beta 1/2.
It's very unlikely that we would consider committing such changes into
released branches. In fact, it's too late even for v15. You should
be submitting non-bug-fix patches against master (v16-to-be).
regards, tom lane
v2-pg16-0001-Avoid-copying-WAL-segments-before-divergence-to-spee.patch
Description: v2-pg16-0001-Avoid-copying-WAL-segments-before-divergence-to-spee.patch
