On Mon, Aug 1, 2022 at 10:42 PM Japin Li <japi...@hotmail.com> wrote:
> > On Mon, 01 Aug 2022 at 22:16, Tom Lane <t...@sss.pgh.pa.us> wrote: > > John Naylor <john.nay...@enterprisedb.com> writes: > >> You are correct, but I wonder if it'd be better to just drop the comment > >> entirely. I checked a couple other random headers with function > >> declarations and they didn't have such a comment, and it's kind of > obvious > >> what they're for. > > > > Some places have these, some don't. It's probably more useful where > > a header foo.h is declaring functions that aren't in the obviously > > corresponding foo.c file, or live in multiple files. In this case > > I agree it's not adding much. > > > > Attached patch to remove this comment. Please take a look. I'm not sure that we should remove such comments. And a rough search shows that there are much more places with this kind of comments, such as below: nbtxlog transam readfuncs walreceiver buffile bufmgr fd latch pmsignal procsignal sinvaladt logtape rangetypes Thanks Richard
