On Wed, Aug 3, 2022 12:06 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > I've attached updated patches that incorporated the above comments as > well as the comments from Shi yu. Please review them. >
Thanks for updating the patch. I noticed that in SnapBuildXidSetCatalogChanges(), "i" is initialized in the if branch in REL10 patch, which is different from REL11 patch. Maybe we can modify REL11 patch to be consistent with REL10 patch. The rest of the patch looks good to me. Regards, Shi yu