(Coming from https://postgr.es/m/20220809193616.5uucf33piwdxn452@alvherre.pgsql
)
On 2022-Aug-09, Alvaro Herrera wrote:
> On 2022-Aug-09, Andres Freund wrote:
>
> > Mildly wondering whether we ought to use designated initializers instead,
> > given we're whacking it around already. Too easy to get the order wrong when
> > adding new members, and we might want to have optional callbacks too.
>
> Strong +1. It makes code much easier to navigate (see XmlTableRoutine
> and compare with heapam_methods, for example).
For example, I propose the attached.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"El que vive para el futuro es un iluso, y el que vive para el pasado,
un imbécil" (Luis Adler, "Los tripulantes de la noche")
>From 66f5981751cdaeb27a0614ca2b0643632f7cc128 Mon Sep 17 00:00:00 2001
From: Alvaro Herrera <alvhe...@alvh.no-ip.org>
Date: Wed, 10 Aug 2022 15:57:09 +0200
Subject: [PATCH] use designated initializors
---
.../libpqwalreceiver/libpqwalreceiver.c | 30 +++++++++----------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
index da9c359af1..2865024524 100644
--- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
+++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
@@ -82,21 +82,21 @@ static WalRcvExecResult *libpqrcv_exec(WalReceiverConn *conn,
static void libpqrcv_disconnect(WalReceiverConn *conn);
static WalReceiverFunctionsType PQWalReceiverFunctions = {
- libpqrcv_connect,
- libpqrcv_check_conninfo,
- libpqrcv_get_conninfo,
- libpqrcv_get_senderinfo,
- libpqrcv_identify_system,
- libpqrcv_server_version,
- libpqrcv_readtimelinehistoryfile,
- libpqrcv_startstreaming,
- libpqrcv_endstreaming,
- libpqrcv_receive,
- libpqrcv_send,
- libpqrcv_create_slot,
- libpqrcv_get_backend_pid,
- libpqrcv_exec,
- libpqrcv_disconnect
+ .walrcv_connect = libpqrcv_connect,
+ .walrcv_check_conninfo = libpqrcv_check_conninfo,
+ .walrcv_get_conninfo = libpqrcv_get_conninfo,
+ .walrcv_get_senderinfo = libpqrcv_get_senderinfo,
+ .walrcv_identify_system = libpqrcv_identify_system,
+ .walrcv_server_version = libpqrcv_server_version,
+ .walrcv_readtimelinehistoryfile = libpqrcv_readtimelinehistoryfile,
+ .walrcv_startstreaming = libpqrcv_startstreaming,
+ .walrcv_endstreaming = libpqrcv_endstreaming,
+ .walrcv_receive = libpqrcv_receive,
+ .walrcv_send = libpqrcv_send,
+ .walrcv_create_slot = libpqrcv_create_slot,
+ .walrcv_get_backend_pid = libpqrcv_get_backend_pid,
+ .walrcv_exec = libpqrcv_exec,
+ .walrcv_disconnect = libpqrcv_disconnect
};
/* Prototypes for private functions */
--
2.30.2
