Hi,

>
> FYI, I noticed that v5 causes cfbot failure in [1].
> Could you please fix it in the next version ?
>

Thanks for letting me know!


>
> [19:44:38.420] execReplication.c: In function
> ‘RelationFindReplTupleByIndex’:
> [19:44:38.420] execReplication.c:186:24: error: ‘eq’ may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
> [19:44:38.420]   186 |   if (!indisunique && !tuples_equal(outslot,
> searchslot, eq))
> [19:44:38.420]       |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [19:44:38.420] cc1: all warnings being treated as errors
>
>
It is kind of interesting that the compiler cannot understand that `eq` is
only used when *!indisunique. *Anyway, now I've sent v6 where I avoid the
warning with a slight refactor to avoid the compile warning.

Thanks,
Onder KALACI

Attachment: v6_0001_use_index_on_subs_when_pub_rep_ident_full.patch
Description: Binary data

Reply via email to