Here are some review comments for the patch v23-0004: ======
4.1 src/test/subscription/t/032_streaming_apply.pl This test file was introduced in patch 0003, but I think there are a few changes in this 0004 patch which are really have nothing to do with 0004 and should have been included in the original 0003. e.g. There are multiple comments like below - these belong back in the 0003 patch # Wait for this streaming transaction to be applied in the apply worker. # Wait for this streaming transaction to be applied in the apply worker. # Wait for this streaming transaction to be applied in the apply worker. # Wait for this streaming transaction to be applied in the apply worker. # Wait for this streaming transaction to be applied in the apply worker. # Wait for this streaming transaction to be applied in the apply worker. # Wait for this streaming transaction to be applied in the apply worker. # Wait for this streaming transaction to be applied in the apply worker. # Wait for this streaming transaction to be applied in the apply worker. # Wait for this streaming transaction to be applied in the apply worker. # Wait for this streaming transaction to be applied in the apply worker. ~~~ 4.2 @@ -166,17 +175,6 @@ CREATE TRIGGER tri_tab1_unsafe BEFORE INSERT ON public.test_tab1 FOR EACH ROW EXECUTE PROCEDURE trigger_func_tab1_unsafe(); ALTER TABLE test_tab1 ENABLE REPLICA TRIGGER tri_tab1_unsafe; - -CREATE FUNCTION trigger_func_tab1_safe() RETURNS TRIGGER AS \$\$ - BEGIN - RAISE NOTICE 'test for safe trigger function'; - RETURN NEW; - END -\$\$ language plpgsql; -ALTER FUNCTION trigger_func_tab1_safe IMMUTABLE; -CREATE TRIGGER tri_tab1_safe -BEFORE INSERT ON public.test_tab1 -FOR EACH ROW EXECUTE PROCEDURE trigger_func_tab1_safe(); }); I didn't understand why all this trigger_func_tab1_safe which was added in patch 0003 is now getting removed in patch 0004. Maybe there is some good reason, but it doesn't seem right to be adding code in one patch and then removing it again in the next patch. ------ Kind Regards, Peter Smith. Fujitsu Australia
