Re: Schema variables - new implementation for Postgres 15

[Erik Rijkers]

Op 20-08-2022 om 20:09 schreef Pavel Stehule:
Hi
  LET public.svar2 = (10, 20, 30);
  ALTER TYPE public.svar_test_type DROP ATTRIBUTE b;
  SELECT public.svar;
- svar
--------
- (10,)
+  svar
+---------
+ (10,16)
  (1 row)

  SELECT public.svar2;
    svar2
  ---------
   (10,30)
  (1 row)


I hope so I found this error. It should be fixed
 > [patches v20220820-1-0001 -> 0012]


I'm afraid it still gives the same errors during  'make check', and 
again only errors when compiling  without  --enable-cassert

Thanks,

Erik


Regards

Pavel
diff -U3 
/home/aardvark/pg_stuff/pg_sandbox/pgsql.schema_variables/src/test/regress/expected/session_variables.out
 
/home/aardvark/pg_stuff/pg_sandbox/pgsql.schema_variables/src/test/regress/results/session_variables.out
--- 
/home/aardvark/pg_stuff/pg_sandbox/pgsql.schema_variables/src/test/regress/expected/session_variables.out
   2022-08-20 20:12:34.558069463 +0200
+++ 
/home/aardvark/pg_stuff/pg_sandbox/pgsql.schema_variables/src/test/regress/results/session_variables.out
    2022-08-20 20:21:38.028404785 +0200
@@ -990,9 +990,9 @@
 ALTER TYPE public.svar_test_type ADD ATTRIBUTE c int;
 -- should to fail too (different type, different generation number);
 SELECT public.svar;
-   svar   
-----------
- (10,20,)
+   svar    
+-----------
+ (10,20,0)
 (1 row)
 
 LET public.svar = ROW(10,20,30);
@@ -1111,17 +1111,17 @@
 LET public.svar = (10, 20);
 ALTER TYPE public.svar_test_type ADD ATTRIBUTE c int;
 SELECT public.svar;
-   svar   
-----------
- (10,20,)
+    svar    
+------------
+ (10,20,16)
 (1 row)
 
 LET public.svar2 = (10, 20, 30);
 ALTER TYPE public.svar_test_type DROP ATTRIBUTE b;
 SELECT public.svar;
- svar  
--------
- (10,)
+  svar   
+---------
+ (10,16)
 (1 row)
 
 SELECT public.svar2;