On Sat, Aug 27, 2022 at 4:15 AM Andres Freund <and...@anarazel.de> wrote: > > Hi, > > On 2022-08-26 17:05:52 -0400, Andrew Dunstan wrote: > > On 2022-08-26 Fr 10:47, Andres Freund wrote: > > > Given the crazy defines of stuff like free, it seems like a good idea to > > > have > > > a rule that no headers should be included after plperl.h with > > > PG_NEED_PERL_XSUB_H defined. It's not like there's not other chances of > > > of > > > pulling in malloc.h from within pg_wchar.h somehow. > > > > > > It's a bit ugly to have the mb/pg_wchar.h in plperl.h instead of > > > plperl_helpers.h, but ... > > > It's already included directly in plperl.c, so couldn't we just lift it > > directly into SPI.xs and Util.xs? > > I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the > include in plperl.h would keep that aspect transparent, because plperl_utils.h > includes plperl.h.
Since plperl_helpers.h already includes plperl.h, I'm not sure why both are included everywhere the former is. If .c/.xs files didn't include plperl.h directly, we could keep pg_wchar.h in plperl_helpers.h. Not sure if that's workable or any better... -- John Naylor EDB: http://www.enterprisedb.com
