David Rowley <dgrowle...@gmail.com> writes: > I suspect, going by all 3 failing animals being 32-bit which have a > MAXIMUM_ALIGNOF 8 and SIZEOF_SIZE_T of 4 that this is due to the lack > of padding in the MemoryChunk struct. > AllocChunkData and GenerationChunk had padding to account for > sizeof(Size) being 4 and sizeof(void *) being 8, I didn't add that to > MemoryChunk, so I'll do that now.
Doesn't seem to have fixed it. IMO, the fact that we can get through core regression tests and pg_upgrade is a strong indicator that there's not anything fundamentally wrong with memory context management. I'm inclined to think the problem is in d2169c9985, instead ... though I can't see anything wrong with it. Another possibility is that there's a pre-existing bug in the logical decoding stuff that your changes accidentally exposed. I wonder if valgrind would show anything interesting. regards, tom lane