I've noticed that some callers of PathNameOpenFile() (e.g. bbsink_server_begin_archive()) consider the call failed even if the function returned zero, while other ones do check whether the file descriptor is strictly negative. Since the file descriptor is actually returned by the open() system call, I assume that zero is a valid result, isn't it?
-- Antonin Houska Web: https://www.cybertec-postgresql.com