Hello hackers!
Reading docs for the MERGE statement I've found a little error: a
semicolon in middle of a statement and absence of a semicolon in the end
of it.
Key words in subqueries are written in uppercase everywhere in the docs
but not in an example for MERGE. I think it should be adjusted too.
Also aliases, table and column names are written in lowercase
(snake_case) almost all over the docs. I did not dare to fix examples in
the same patch (may be that style was intentional), but guess that style
of the first two examples should not differ from the third one and from
other examples in docs.
Discussions about MERGE was:
https://postgr.es/m/20220801145257.ga15...@telsasoft.com
https://postgr.es/m/20220714162618.gh18...@telsasoft.com
but I did not find there (via quick search) anything about case styling.
Thank all a lot in advance!
--
Best regards,
Vitaly Burovoy
From 7f38cd4c5215fd9933557e1805857c10afba097e Mon Sep 17 00:00:00 2001
From: Vitaly Burovoy <vitaly.buro...@gmail.com>
Date: Wed, 7 Sep 2022 19:38:58 +0000
Subject: [PATCH 1/2] Doc fix for MERGE statement
---
doc/src/sgml/ref/merge.sgml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/src/sgml/ref/merge.sgml b/doc/src/sgml/ref/merge.sgml
index a129a6edd5..2db6b7e698 100644
--- a/doc/src/sgml/ref/merge.sgml
+++ b/doc/src/sgml/ref/merge.sgml
@@ -576,13 +576,13 @@ WHEN NOT MATCHED THEN
<programlisting>
MERGE INTO CustomerAccount CA
-USING (Select CustomerId, TransactionValue From RecentTransactions) AS T
+USING (SELECT CustomerId, TransactionValue FROM RecentTransactions) AS T
ON T.CustomerId = CA.CustomerId
WHEN MATCHED THEN
- UPDATE SET Balance = Balance + TransactionValue;
+ UPDATE SET Balance = Balance + TransactionValue
WHEN NOT MATCHED THEN
INSERT (CustomerId, Balance)
- VALUES (T.CustomerId, T.TransactionValue)
+ VALUES (T.CustomerId, T.TransactionValue);
</programlisting>
</para>
--
2.35.1
From f59cc9ef227d96a8e3b22ef993ad79f407be9ec8 Mon Sep 17 00:00:00 2001
From: Vitaly Burovoy <vitaly.buro...@gmail.com>
Date: Wed, 7 Sep 2022 20:30:46 +0000
Subject: [PATCH 2/2] Doc styling for MERGE statement
---
doc/src/sgml/ref/merge.sgml | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/doc/src/sgml/ref/merge.sgml b/doc/src/sgml/ref/merge.sgml
index 2db6b7e698..e07addaea4 100644
--- a/doc/src/sgml/ref/merge.sgml
+++ b/doc/src/sgml/ref/merge.sgml
@@ -554,18 +554,18 @@ MERGE <replaceable class="parameter">total_count</replaceable>
<title>Examples</title>
<para>
- Perform maintenance on <literal>CustomerAccounts</literal> based
- upon new <literal>Transactions</literal>.
+ Perform maintenance on <literal>customer_accounts</literal> based
+ upon new <literal>recent_transactions</literal>.
<programlisting>
-MERGE INTO CustomerAccount CA
-USING RecentTransactions T
-ON T.CustomerId = CA.CustomerId
+MERGE INTO customer_account ca
+USING recent_transactions t
+ON t.customer_id = ca.customer_id
WHEN MATCHED THEN
- UPDATE SET Balance = Balance + TransactionValue
+ UPDATE SET balance = balance + transaction_value
WHEN NOT MATCHED THEN
- INSERT (CustomerId, Balance)
- VALUES (T.CustomerId, T.TransactionValue);
+ INSERT (customer_id, balance)
+ VALUES (t.customer_id, t.transaction_value);
</programlisting>
</para>
@@ -575,14 +575,14 @@ WHEN NOT MATCHED THEN
during execution.
<programlisting>
-MERGE INTO CustomerAccount CA
-USING (SELECT CustomerId, TransactionValue FROM RecentTransactions) AS T
-ON T.CustomerId = CA.CustomerId
+MERGE INTO customer_account ca
+USING (SELECT customer_id, transaction_value FROM recent_transactions) AS t
+ON t.customer_id = ca.customer_id
WHEN MATCHED THEN
- UPDATE SET Balance = Balance + TransactionValue
+ UPDATE SET balance = balance + transaction_value
WHEN NOT MATCHED THEN
- INSERT (CustomerId, Balance)
- VALUES (T.CustomerId, T.TransactionValue);
+ INSERT (customer_id, balance)
+ VALUES (t.customer_id, t.transaction_value);
</programlisting>
</para>
--
2.35.1
