Michael Paquier <mich...@paquier.xyz> writes: > And so, I have spent a couple of hours torturing the patch, applying > it after a few tweaks and CI runs: > ... > The buildfarm is green so I think that we are good. I have closed the > open item.
+1, thanks for taking care of that. As far as my original complaint about mamba goes, I've not quite been able to run it to ground. However, I found that NetBSD seems to be shipping unmodified zlib 1.2.11, which contains a number of known bugs in deflate_stored() --- that is, the code path implementing compression level 0. Red Hat for one is carrying several back-patched fixes in that part of zlib. So for the moment I'm willing to write it off as "not our bug". We aren't intentionally testing compression level 0, and hardly anybody would intentionally use it in the field, so it's not really a thing worth worrying about IMO. But if mamba continues to show failures in that test then it will be worth looking closer. regards, tom lane