On Fri, Sep 16, 2022 at 10:51 AM John Naylor <john.nay...@enterprisedb.com> wrote: > > On Fri, Sep 16, 2022 at 10:11 AM Kyotaro Horiguchi > <horikyota....@gmail.com> wrote: > > > > The patch seems to me covering all occurances of PG_PROC as PGPROC. > > +1 since this hinders grep-ability.
Pushed this. > > I found several uses of PG_PROC as (pg_catalog.)pg_proc, which is > > quite confusing, too.. > > It's pretty obvious to me what that refers to in primnodes.h, although > the capitalization of (some, but not all) catalog names in comments in > that file is a bit strange. Maybe not worth changing there. I left this alone. It's not wrong, and I don't think it's confusing in context. -- John Naylor EDB: http://www.enterprisedb.com
