On Wed, Sep 28, 2022 at 9:16 AM Robert Haas <robertmh...@gmail.com> wrote: > I agree. I should have gone through and checked that every place where > RelFileLocator got embedded in some larger struct, there was no > problem with making it bigger and increasing the alignment > requirement. I'll go back and do that as soon as the immediate > problems are fixed. This case would have stood out as something > needing attention.
On second thought, I'm going to revert the whole thing. There's a bigger mess here than can be cleaned up on the fly. The alignment-related mess in ParseCommitRecord is maybe something for which I could just hack a quick fix, but what I've also just now realized is that this makes a huge number of WAL records larger by 4 bytes, since most WAL records will contain a block reference. I don't know whether that's OK or not, but I do know that it hasn't been thought about, and after commit is not the time to begin experimenting with such things. -- Robert Haas EDB: http://www.enterprisedb.com
