On 9/7/22 12:03, Dave Page wrote:
Here's a v4 patch. This reverts to using GetCurrentTransactionStopTimestamp() for the last_scan times, and will set xactStopTimestamp the first time GetCurrentTransactionStopTimestamp() is called, thus avoiding multiple gettimeofday() calls. SetCurrentTransactionStopTimestamp() is removed, as is use of xactStopTimestamp (except when resetting it to 0).
This patch looks good to me and has much saner behavior than what it replaces.
As a matter of process, the oid for the new function should be in the 8000-9000 range and the catversion should be bumped by the committer.
Marked as Ready for Committer. Thanks for the patch! -- Vik Fearing
