On Wednesday, September 28, 2022 5:36 PM Wang, Wei/王 威 <wangw.f...@fujitsu.com>
wrote:
> Also rebased the patch because the change in the HEAD (20b6847).
>
> Attach the new patches.
Hi, thank you for the updated patches!
Here are my minor review comments for HEAD v12.
(1) typo & suggestion to reword one comment
+ * Publications support partitioned tables. If
+ * publish_via_partition_root is false, all changes are
replicated
+ * using leaf partition identity and schema, so we only
need
+ * those. Otherwise, If publish_via_partition_root is
true, get
+ * the partitioned table itself.
The last sentence has "If" in the middle of the sentence.
We can use the lower letter for it. Or, I think "Otherwise" by itself means
"If publish_via_partition_root is true". So, I'll suggest a below change.
FROM:
Otherwise, If publish_via_partition_root is true, get the partitioned table
itself.
TO:
Otherwise, get the partitioned table itself.
(2) Do we need to get "attnames" column from the publisher in the
fetch_table_list() ?
When I was looking at v16 path, I didn't see any codes that utilize
the "attnames" column information returned from the publisher.
If we don't need it, could we remove it ?
I can miss something greatly, but this might be affected by HEAD codes ?
Best Regards,
Takamichi Osumi
