Hi, On 2022-10-06 09:06:42 +0200, Peter Eisentraut wrote: > On 05.10.22 21:08, Andres Freund wrote: > > This is a patch split off from the initial meson thread [1] as it's > > functionally largely independent (as suggested in [2]). > > > > Using precompiled headers substantially speeds up building for windows, due > > to > > the vast amount of headers included via windows.h. A cross build from > > linux targetting mingw goes from > > These patches look ok to me. I can't really comment on the Windows details, > but it sounds all reasonable.
Thanks for reviewing! > Small issue: > > +override CFLAGS += -DFD_SETSIZE=1024 > > (and similar) > > should be CPPFLAGS. Pushed with that adjusted. Greetings, Andres Freund
