On Thu, Oct 13, 2022 at 10:55:08AM -0700, Zhihong Yu wrote: > Hi, > I was looking at combo_init in contrib/pgcrypto/px.c . > > There is a memset() call following palloc0() - the call is redundant. > > Please see the patch for the proposed change. > > Thanks
> diff --git a/contrib/pgcrypto/px.c b/contrib/pgcrypto/px.c > index 3b098c6151..d35ccca777 100644 > --- a/contrib/pgcrypto/px.c > +++ b/contrib/pgcrypto/px.c > @@ -203,7 +203,6 @@ combo_init(PX_Combo *cx, const uint8 *key, unsigned klen, > if (klen > ks) > klen = ks; > keybuf = palloc0(ks); > - memset(keybuf, 0, ks); > memcpy(keybuf, key, klen); > > err = px_cipher_init(c, keybuf, klen, ivbuf); Uh, the memset() is ks length but the memcpy() is klen, and the above test allows ks to be larger than klen. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson
