On Tue, Oct 18, 2022 5:44 PM Peter Smith <smithpb2...@gmail.com> wrote: > > On Mon, Oct 17, 2022 at 7:11 PM shiy.f...@fujitsu.com > <shiy.f...@fujitsu.com> wrote: > > > ... > > > > Thanks for your patch. Here are some comments. > > > > In Example 2, the returned slot_name should be "myslot". > > > > +test_pub=# SELECT * FROM pg_create_logical_replication_slot('myslot', > 'pgoutput'); > > + slot_name | lsn > > +-----------+----------- > > + sub1 | 0/19059A0 > > +(1 row) > > > > Oops. Sorry for my cut/paste error. Fixed in patch v6. > > > > Besides, I am thinking is it possible to slightly simplify the example. For > > example, merge example 1 and 2, keep the steps of example 2 and in the > step of > > creating slot, mention what should we do if slot_name is not specified when > > creating subscription. > > > > Sure, it might be a bit shorter to combine the examples, but I thought > it’s just simpler not to do it that way because the combined example > will then need additional bullets/notes to say – “if there is no > slot_name do this…” and “if there is a slot_name do that…”. It’s > really only the activation part which is identical for both. >
Thanks for updating the patch. +test_sub=# CREATE SUBSCRIPTION sub1 +test_sub-# CONNECTION 'host=localhost dbname=test_pub' +test_sub-# PUBLICATION pub1 +test_sub-# WITH (slot_name=NONE, enabled=false, create_slot=false); +WARNING: subscription was created, but is not connected +HINT: To initiate replication, you must manually create the replication slot, enable the subscription, and refresh the subscription. +CREATE SUBSCRIPTION In example 3, there is actually no such warning message when creating subscription because "connect=false" is not specified. I have tested the examples in the patch and didn't see any problem other than the one above. Regards, Shi yu