On Mon, Oct 31, 2022 at 11:50 AM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > On Mon, Oct 31, 2022 at 5:01 AM Michael Paquier <mich...@paquier.xyz> wrote: > > > > On Sun, Oct 30, 2022 at 03:44:32PM +0100, Alvaro Herrera wrote: > > > So I'm kinda proposing that we only do the forward struct initialization > > > dance when it really saves on things -- in particular, when it helps > > > avoid or reduce massive indirect header inclusion. > > > > Sure. > > I don't think including pg_iovec.h in file_utils.h is a good idea. I > agree that pg_iovec.h is fairly a small header file but file_utils.h > is included in 21 .c files, as of today and the file_utils.h footprint > might increase in future. Therefore, I'd vote for forward struct > initialization as it is on HEAD today.
I'm attaching the v9 patch from upthread here again for further review and to make CF bot happy. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
v9-0001-Use-pg_pwritev_with_retry-instead-of-write-in-wal.patch
Description: Binary data
