On 11/3/22 15:50, Tom Lane wrote:
Seems reasonable, so done (I fixed one additional spot you missed).
Thanks!
The bigger picture here is that we do actually endeavor to keep (most of) our headers C++ clean, but our tool cpluspluscheck misses these problems because it doesn't try to use these macros. I wonder whether there is a way to do better.
What about having a custom header alongside cpluspluscheck which references all macros we care about? We could start with the really big macros like the ones from simplehash.h and add as we go.
I could give this a try if deemed useful. -- David Geier (ServiceNow)
