On Fri, Nov 04, 2022 at 07:59:01PM +0800, Julien Rouhaud wrote: > On Thu, Nov 03, 2022 at 10:22:15PM +0100, Pavel Stehule wrote: > > čt 3. 11. 2022 v 5:09 odesílatel Julien Rouhaud <rjuju...@gmail.com> napsal: > > updated patch attached > > > > big thanks for these comments and tips > > Thanks for the updated patch! As far as I'm concerned the patch is in a good > shape, passes the CI and I don't have anything more to say so I'm marking it > as > Ready for Committer!
+1 I started looking to see if it's possible to simplify the patch at all, but nothing to show yet. But one thing I noticed is that "optarg" looks wrong here: simple_string_list_append(&opts->triggerNames, optarg); -- Justin