On Mon, 7 Nov 2022 at 08:55, Karina Litskevich <litskevichkar...@gmail.com> wrote: > > Hi David, > > > I am not very clear about why `build_reloptions` is removed in patch > > `v2-0002-better-error-message-for-setting-parameters-for-p.patch`, if > > you can help explain would be great. > > "build_reloptions" parses "reloptions" and takes for it a list of allowed > options defined by the 5th argument "relopt_elems" and the 6th argument > "num_relopt_elems", which are NULL and 0 in the removed call. If "validate" > is false, it ignores options, which are not in the list, while parsing. If > "validate" is true, it "elog"s ERROR when it meets option, which is not in the > allowed list.
Karina's changes make sense to me, so +1. This is a minor patch, so I will set this as Ready For Committer. -- Simon Riggs http://www.EnterpriseDB.com/
