On Thu, Nov 10, 2022 at 4:07 PM sirisha chamarthi <sirichamarth...@gmail.com> wrote: > > On Wed, Nov 9, 2022 at 2:37 AM Amit Kapila <amit.kapil...@gmail.com> wrote: >> >> On Fri, Nov 4, 2022 at 1:40 PM sirisha chamarthi >> <sirichamarth...@gmail.com> wrote: >> > >> Is the intent of setting restart_lsn to InvalidXLogRecPtr was to >> disallow reviving the slot? >> > >> >> I think the intent is to compute the correct value for >> replicationSlotMinLSN as we use restart_lsn for it and using the >> invalidated slot's restart_lsn value for it doesn't make sense. > > > Correct. If a slot is invalidated (lost), then shouldn't we ignore the slot > from computing the catalog_xmin? I don't see it being set to > InvalidTransactionId in ReplicationSlotsComputeRequiredXmin. Attached a small > patch to address this and the output after the patch is as shown below. >
I think you forgot to attach the patch. However, I suggest you start a separate thread for this because the patch you are talking about here seems to be for an existing problem. -- With Regards, Amit Kapila.
