> On 10 Aug 2022, at 10:28, Daniel Gustafsson <dan...@yesql.se> wrote:
> 
>> On 10 Aug 2022, at 08:12, Kyotaro Horiguchi <horikyota....@gmail.com> wrote:
>> 
>> (I suppose this is a pg15 issue)
>> 
>> createuser --help shows the following help text.
>> 
>>> --bypassrls               role can bypass row-level security (RLS) policy
>>> --no-bypassrls            role cannot bypass row-level security (RLS) policy
>>> --replication             role can initiate replication
>>> --no-replication          role cannot initiate replication
>> 
>> For other options the text tells which one is the default, which I
>> think the two options also should have the same.
> 
> Agreed.  For --no-replication the docs in createuser.sgml should fixed to
> include a "This is the default" sentence like the others have as well.

>> The ternary options are checked against decimal 0, but it should use
>> TRI_DEFAULT instead. (attached third)
> 
> Agreed, nice catch.

Attached is my proposal for this, combining your 0001 and 0003 patches with
some docs and test fixups to match.

--
Daniel Gustafsson               https://vmware.com/

Attachment: v2-0001-Fix-handling-of-default-option-values-in-createus.patch
Description: Binary data

Reply via email to